summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* dwm crashes when opening 50+ clients (tile layout)bakkeby2020-04-251-2/+4
| | | | | | | | Many users new to dwm find themselves caught out by being kicked out to the login manager (dwm crashing) when they open 50+ clients for demonstration purposes. The number of clients reported varies depending on the resolution of the monitor. The cause of this is due to how the default tile layout calculates the height of the next client based on the position of the previous client. Because clients have a minimum size the (ty) position can exceed that of the window height, resulting in (m->wh - ty) becoming negative. The negative height stored as an unsigned int results in a very large height ultimately resulting in dwm crashing. This patch adds safeguards to prevent the ty and my positions from exceeding that of the window height.
* drawbar: Don't shadow sw globalChris Down2020-04-221-4/+4
| | | | | | | This jarred me a bit while reading the code, since "sw" usually refers to the global screen geometry, but in drawbar() only it refers to text-related geometry. Renaming it makes it more obvious that these are not related.
* getatomprop: Add forward declarationChris Down2020-04-221-0/+1
| | | | | No functional changes, but for every other function we have a forward declaration here. getatomprop should be no exception.
* setmfact: Unify bounds for compile-time and runtime mfactChris Down2020-04-201-1/+1
| | | | | | | | | | | | | | | | | | | | There are two places that mfact can be set: - In the mfact global, which is defined at compile time and passed into m->mfact during monitor setup. No bounds checks are performed, but the comment alongside it says that valid values are [0.05..0.95]: static const float mfact = 0.55; /* factor of master area size [0.05..0.95] */ - By setmfact, which adjusts m->mfact at runtime. It also does some minimum and maximum bounds checks, allowing [0.1..0.9]. Values outside of that range are ignored, and mfact is not adjusted. These different thresholds mean that one cannot setmfact 0.95 or 0.05, despite the comment above that lists the legal range for mfact. Clarify this by enforcing the same bounds in setmfact at runtime as those listed for mfact at compile time.
* config.mk: fix POSIX_C_SOURCE macro for feature test for snprintf()Hiltjo Posthuma2020-04-031-1/+1
| | | | | | | | | | | | | | | | | | | The feature test was incorrect: _POSIX_C_SOURCE=2 "The value 2 or greater additionally exposes definitions for POSIX.2-1992." http://man7.org/linux/man-pages/man7/feature_test_macros.7.html A higher value is needed (atleast 1995): https://pubs.opengroup.org/onlinepubs/9699919799/functions/snprintf.html FreeBSD feature test macro: on https://github.com/freebsd/freebsd/blob/master/include/stdio.h line 297 This was already fixed in dmenu. This fixes a warning on FreeBSD, reported by Plasmoduck on IRC, thanks.
* Prepare 6.2 release.Anselm R Garbe2019-02-023-3/+17
|
* pledge: add rpath promise for the ugly Xft font fallbackHiltjo Posthuma2018-06-021-1/+1
|
* Makefile: just show the compiler outputHiltjo Posthuma2018-06-021-26/+17
| | | | Don't be fancy and just show the actual output so debugging is simpler.
* Do not strip at link stageKlemens Nanni2018-06-021-1/+1
| | | | | Building with debug symbols is worthless unless LDFLAGS are manually adjusted as well.
* Pledge on OpenBSDKlemens Nanni2018-05-251-0/+4
|
* config.def.h: ClkTagBar missing from commentHiltjo Posthuma2018-05-251-1/+1
| | | | | | | by Christopher Drelich <cd@cdrakka.com> Patch was mangled on the ML, also adjusted the order to be the same as the enum in dwm.c
* Function declarations in correct order.Christopher Drelich2018-05-121-1/+1
| | | | | | | In dwm.c function declarations are in alphabetical order except for updategeom(). There doesn't appear to be any reason for this, so this patch corrects that, and now all function declarations are in alphabetical order.
* remove old TODO and BUGS entriesHiltjo Posthuma2018-05-124-58/+4
| | | | | | the bug in the dwm man page is an (ancient) Java issue. Thanks David and quinq for the patches and feedback!
* update README: remove mentioning the old dextra repoHiltjo Posthuma2018-03-141-3/+0
| | | | Thanks Christopher Drelich <cd@cdrakka.com>
* All functions in alphabetical order except for this one.Christopher Drelich2018-03-141-9/+9
|
* ColBorder has been moved to the enum with ColFg and ColBg.Christopher Drelich2018-03-142-2/+1
|
* dont NUL terminate _NET_WM_NAMEHiltjo Posthuma2017-12-271-1/+1
| | | | | | | | | | | | | | | Reported by Kernc, thanks! "This makes a particular program that uses libwnck [1] fail after: Wnck-WARNING **: Property _NET_WM_NAME contained invalid UTF-8 in this code [2] because the returned string contains a '\0' and the documentation for g_utf8_validate() [3] explicitly states that when string length is provided, no nul bytes are allowed." It is not entirely clear it is incorrect, other WM's seem to not NUL terminate it either though.
* sync dmenu drw.{c,h} code: use Clr* (was Scm)Hiltjo Posthuma2017-11-033-13/+13
|
* gettextprop: check result of XGetTextProperty (undefined behaviour for XFree)Hiltjo Posthuma2017-11-031-2/+1
|
* Set class name on status barOmar Sandoval2017-11-031-0/+2
| | | | | This is useful for configuring compositors to ignore the status bar window.
* simplify isfixed conditionsDaniel Cousens2017-10-111-2/+1
|
* yet another cleanupAnselm R Garbe2017-05-082-35/+35
| | | | | The previous patches introduced some unclean space-based indentation patterns. This patch fixes them.
* Don't restrict snap in mousemoveMarkus Teich2017-03-281-14/+11
| | | | | This also fixes a bug where client windows only switch to floating mode when the mouse is dragged in one specific direction.
* Button passthrough when client is not focusedMarkus Teich2017-03-281-10/+11
| | | | | | | | | | | Before this change it is not possible to press a button in a client on the first click if the client is not yet focused. The first click on the button would only focus the client and a second click on the button is needed to activate it. This situation can occur when moving the mouse over a client (therefore focusing it) and then moving the focus to another client with keyboard shortcuts. After this commit the behavior is fixed and button presses on unfocused clients are passed to the client correctly.
* cleanupMarkus Teich2017-03-283-36/+32
| | | | | | | | | | | | | | - unify multi-line expression alignment style. - unify multi-line function call alignment style. - simplify client moving on monitor count decrease. - clarify comment for focusin(). - remove old confusing comment about input focus fix in focusmon(). The explanation is already in the old commit message, so no need to keep it in the code. - remove old comment describing even older state of the code in focus(). - unify comment style. - break up some long lines. - fix some typos and grammar.
* applied Markus' tagset purge of alternative view on _NET_ACTIVE_WINDOW eventAnselm R Garbe2016-12-051-20/+18
|
* applied Ivan Delalande's NET_SUPPORTING_WM_CHECK patch for gtk3 compatibilityAnselm R Garbe2016-12-051-2/+14
|
* applied Ian Remmler's man page adjustment suggestionsAnselm R Garbe2016-12-051-4/+5
|
* applied Markus' decouple color-scheme patchAnselm R Garbe2016-12-052-6/+8
|
* applied Markus' clarify status text padding patchAnselm R Garbe2016-12-051-2/+2
|
* LICENSE: update peopleQuentin Rameau2016-11-151-6/+10
|
* dwm.1: add keybinding for spawning dmenuQuentin Rameau2016-11-151-0/+5
|
* die() on calloc failureHiltjo Posthuma2016-11-051-1/+1
| | | | thanks Markus Teich and David!
* die() consistency: always add newlineHiltjo Posthuma2016-08-123-8/+10
|
* config.def.h: style improvement, use color Scheme enumHiltjo Posthuma2016-06-281-4/+4
|
* import new drw from libsl and minor fixes.Markus Teich2016-06-265-208/+209
| | | | | - better scaling for occupied tag squares. - draw statusline first to omitt some complicated calculations.
* Configure geometry before applying rulesEric Pruitt2016-06-241-6/+7
| | | | | | Configuring geometry before applying rules makes it possible to have more complex constraints in applyrules that depend on the initial window dimensions and location.
* fix fullscreen clients not resized on X display resolution changeHiltjo Posthuma2015-12-191-1/+6
| | | | patch provided by Bert Münnich <ber.t_AT_posteo.de>, thanks!
* Shut up glibc about _BSD_SOURCE being deprecatedQuentin Rameau2015-12-191-1/+1
|
* code-style consistencyHiltjo Posthuma2015-11-081-433/+503
|
* unboolificationHiltjo Posthuma2015-11-082-78/+77
|
* sort include + whitespace fixHiltjo Posthuma2015-11-081-3/+3
|
* separate program-specific c99 bool and X11Hiltjo Posthuma2015-11-082-75/+77
| | | | | True, False are X11-specific (int), make sure to use c99 stdbool for program-specific things.
* Makefile: package all files with make distHiltjo Posthuma2015-11-081-2/+2
|
* setfullscreen: don't process the property twiceQuentin Rameau2015-11-071-2/+2
| | | | | | | | | | Some clients try to set _NET_WM_STATE_FULLSCREEN even when the window is already in fullscreen. For example, c->oldstate was set two times in a raw and window would then always be floating. We must check that it's not the case before processing it. (original patch modified with suggestion from Markus Teich <markus.teich@stusta.mhn.de>)
* sync updated drw code from dmenuHiltjo Posthuma2015-10-205-158/+164
| | | | | | important: - drw_rect: didn't use w and h, change the dwm code accordingly. - drw_text: text is NULL is not allowed, use drw_rect().
* dwm: use ecalloc, prevent theoretical overflowHiltjo Posthuma2015-10-201-6/+3
|
* cleanup, dont use c++ style commentsHiltjo Posthuma2015-10-201-4/+4
| | | | | | - signal: print error string. - die: start message with lower-case (consistency). - bump version to 2015.
* dwm: cleanup: free schemes and cursors as arrayHiltjo Posthuma2015-10-201-9/+8
|
* config.h: use common default font, pass Xft font name to dmenuHiltjo Posthuma2015-10-201-4/+2
| | | | dmenu uses Xft now (soon to be released).
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-22 19:51:44 +0000